[p-dev] [PATCH] Add CONTRIBUTING.md file

Gert Meulyzer info at gertm.eu
Thu Feb 11 00:46:14 AEDT 2016


I agree with this.

Nitpicking below:

On Wed, Feb 10, 2016 at 2:18 PM, <paul at plasmalang.org> wrote:
>
> +## Before beginning
> +
> +It is usually best to start each piece of work on a new git branch.
> Create
>

Usually? I'd say 'always' since I can't think of a situation in which this
wouldn't be the case.
(For spelling errors etc, I'd bundle them up in 1 big patch and commit it
in a branch.)

<snip>

+Search the source code for the strings "XXX" or "TODO" for things that must
> +be handled.  Keep in mind that there may be good reasons why these are not
> +yet handled, eg: other work needs doing first.
>

Perhaps we could refer again to the 'talk to us' section here.

Other than these two extremely minor things, I have no remarks.

Gert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.plasmalang.org/list-archives/dev/attachments/20160210/f0ee28dd/attachment.html>


More information about the dev mailing list